Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic setting extra HTTP headers #116

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Fix panic setting extra HTTP headers #116

merged 3 commits into from
Nov 16, 2021

Conversation

imiric
Copy link
Contributor

@imiric imiric commented Nov 15, 2021 •
edited
Loading

Closes #111

Also fixes it for Page.SetExtraHTTPHeaders().

@imiric imiric force-pushed the fix/111-panic-extrahttpheaders branch from ccef734 to 2af14d7 Compare November 15, 2021 14:41
@imiric
Copy link
Contributor Author

imiric commented Nov 15, 2021

The E2E CI failure (502 Bad Gateway) is actually from gopkg.in, not GitHub. The strange thing is that building the extension works fine for me locally... 🤷‍♂️

robingustafsson
robingustafsson approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@robingustafsson robingustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imiric imiric merged commit baaf58c into main Nov 16, 2021
@imiric imiric deleted the fix/111-panic-extrahttpheaders branch November 16, 2021 08:59
@inancgumus
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingustafsson robingustafsson robingustafsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error with extraHTTPHeaders
3 participants
@imiric @inancgumus @robingustafsson