Remove the api package #1055
Merged
Remove the api package #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
refactor/api-package
branch
from
9079775 to
26a796a
Compare
inancgumus
changed the title
inancgumus
force-pushed
the
refactor/api-package
branch
2 times, most recently
from
72b7463 to
f80a2a6
Compare
This is a temporary move until we finish refactoring. We'll make other packages depend on these types until we turn them into concrete types. Then, we'll remove these types from here, and move them into the mapping layer as unexported types for testing.
Packages no longer depends on the api pkg. All API declarations are now inside the common pkg. We'll turn them into concrete types next.
inancgumus
force-pushed
the
refactor/api-package
branch
from
f80a2a6 to
9634828
Compare
ankur22
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
apipkg types withAPIand fixes the linter errors (commits that start with "Rename".)APItypes into thecommonpkg (commits that start with "Move" and "Use".)apipkg for good (commits that start with "Remove".)Why?
apitypes withAPIto distinguish them from thecommontypes. So, we can move them into thecommonpkg.commonpkg is necessary because there are many dependencies to these types throughout the module, and we can only sanely refactor these into concrete types within thecommonpkg.apipkg dependency.See the other reasonings in #898.
Checklist
Related PR(s)/Issue(s)
Updates: #898 (Actually, it finishes the work, but it's better to move the interfaces to concrete types to realize the issue's goal fully).