Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the latest version of k6 #1047

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update to the latest version of k6 #1047

merged 1 commit into from
Sep 26, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Sep 26, 2023

What?

Updating the k6 dependency to the latest from master.

Why?

To take advantage of the latest k6 changes and to ensure that xk6-browser complies with those changes.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@ankur22 ankur22 requested review from ka3de and inancgumus September 26, 2023 11:02
ka3de
ka3de approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ankur22 ankur22 merged commit 9ea5aec into main Sep 26, 2023
12 checks passed
@ankur22 ankur22 deleted the update/k6-master-dep branch September 26, 2023 15:21
@inancgumus inancgumus mentioned this pull request Sep 27, 2023
Merged
3 tasks
@inancgumus inancgumus added the dependencies Pull requests that update a dependency file label Oct 12, 2023
@Porkepix Porkepix mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka3de ka3de ka3de approved these changes

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankur22 @inancgumus @ka3de