Fix context.clearCookies #1040
Merged
Fix context.clearCookies #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
previously approved these changes
Sep 19, 2023
ka3de
reviewed
Sep 19, 2023
ka3de
approved these changes
Sep 19, 2023
Cookies 🍪 🍪!! |
inancgumus
force-pushed
the
fix/clear-cookies
branch
from
019a02d to
31ca8bd
Compare
inancgumus
added a commit
that referenced
this pull request
Sep 20, 2023
inancgumus
added a commit
to grafana/k6-docs
that referenced
this pull request
Sep 20, 2023
This PR solved the issue: grafana/xk6-browser#1040
inancgumus
added a commit
to grafana/k6-docs
that referenced
this pull request
Sep 20, 2023
This PR solved the issue: grafana/xk6-browser#1040
ka3de
pushed a commit
to grafana/k6-docs
that referenced
this pull request
Sep 27, 2023
This PR solved the issue: grafana/xk6-browser#1040
ka3de
pushed a commit
to grafana/k6-docs
that referenced
this pull request
Oct 9, 2023
This PR solved the issue: grafana/xk6-browser#1040
ka3de
pushed a commit
to grafana/k6-docs
that referenced
this pull request
Oct 9, 2023
This PR solved the issue: grafana/xk6-browser#1040
ankur22
added a commit
that referenced
this pull request
Oct 19, 2023
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
ankur22
added a commit
that referenced
this pull request
Oct 23, 2023
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
ankur22
added a commit
that referenced
this pull request
Oct 23, 2023
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
ankur22
added a commit
that referenced
this pull request
Oct 23, 2023
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
ankur22
added a commit
that referenced
this pull request
Oct 23, 2023
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the "unable to clear cookies permissions: invalid context" error. This error occurs when
browserContext.clearCookiesis called. See #442 for details.Why?
The
clearCookiesmethod wasn't using the actual CDP connection.Checklist
Related PR(s)/Issue(s)
Closes #442