Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a LookupBool utility function #1003

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Add a LookupBool utility function #1003

merged 4 commits into from
Aug 18, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Aug 17, 2023 •
edited
Loading

What?

Defines a LookupBool helper.

Why?

To make bool lookup queries less verbose in tests.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes (indirectly)
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus added the dx developer experience label Aug 17, 2023
@inancgumus inancgumus requested review from ankur22 and ka3de August 17, 2023 10:47
@inancgumus inancgumus self-assigned this Aug 17, 2023
@inancgumus inancgumus force-pushed the add/lookup-bool-helper branch from 9de50ce to d141bcb Compare August 17, 2023 10:47
@inancgumus inancgumus changed the title Add a LookupTrue utility function Add a LookupBool utility function Aug 17, 2023
@inancgumus inancgumus force-pushed the add/lookup-bool-helper branch 3 times, most recently from 783314e to 57d052b Compare August 17, 2023 16:34
@inancgumus
Add a LookupBool utility function
f8aa82f 
It makes it a little bit clearer to make these queries.
@inancgumus inancgumus force-pushed the add/lookup-bool-helper branch from 57d052b to f8aa82f Compare August 17, 2023 19:09
ka3de
ka3de reviewed Aug 18, 2023
View reviewed changes
env/env.go Outdated Show resolved Hide resolved
@inancgumus inancgumus added refactor and removed dx developer experience labels Aug 18, 2023
@inancgumus inancgumus requested a review from ka3de August 18, 2023 07:22
ankur22
ankur22 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ka3de
ka3de approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@inancgumus inancgumus merged commit faaf749 into main Aug 18, 2023
@inancgumus inancgumus deleted the add/lookup-bool-helper branch August 18, 2023 11:03
inancgumus added a commit that referenced this pull request Aug 18, 2023
@inancgumus
Update LookupBool to return two bools
2797d09 
Resolves: #1003 (comment)
@inancgumus inancgumus added the productivity Issues and PRs that improve our productivity label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka3de ka3de ka3de approved these changes

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
productivity Issues and PRs that improve our productivity refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @ankur22 @ka3de