-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work with VU.State.Options to validate browser options #858
Comments
Hey @imiric , one question, in relation with this issue and the work done in grafana/k6@948587b. Are we missing a new method definition in the Also, I have one doubt. From |
@ka3de: You're right. A method on Re: your second question, you should be able to get the scenario name the VU is running in in the same way as it's done in the There should be a friendlier API for this eventually, but this will have to do for now. |
Great. Thank you @imiric , and thank you for the example on how to correlate the VU with the scenario 👍 |
This simplifies retrieval of ScenarioOptions, since it avoids type assertions of all possible ExecutorConfig implementations. See grafana/xk6-browser#858 (comment)
This simplifies retrieval of ScenarioOptions, since it avoids type assertions of all possible ExecutorConfig implementations. See grafana/xk6-browser#858 (comment)
Once the
browser
options are part ofscenarios
, we need to be able to validate the options and the env vars. Options should be possible to validate with the use ofVU.State.Options
. One thing to keep in mind is whether we can validate options and env vars before the test run starts so that we can error out and warn users as early as possible.The text was updated successfully, but these errors were encountered: