Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor screenshot to use local persister #1157

Closed
2 tasks done
ankur22 opened this issue Jan 16, 2024 · 0 comments
Closed
2 tasks done

Refactor screenshot to use local persister #1157

ankur22 opened this issue Jan 16, 2024 · 0 comments
Assignees
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 16, 2024

What?

Refactor the current implementation to persist screenshots to the local disk.

Why?

This will help in two ways:

  1. Ensure that the concrete type that was implemented in Implement a local disk persister #1156 behaves as it should;
  2. Move us closer to being able to work with any type that satisfies the interface in Define an interface for local and remote storage #1155.

How?

Do the refactor by working with the interface defined by #1155 and the concrete type defined by #1156.

Tasks

Tasks

Related PR(s)/Issue(s)

Prerequisite issue: #1156

@ankur22 ankur22 added team/k6browser To distinguish the issue on project boards. remote remote browser related labels Jan 16, 2024
@ankur22 ankur22 self-assigned this Jan 25, 2024
@ankur22 ankur22 mentioned this issue Jan 29, 2024
3 tasks
@ankur22 ankur22 closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.
Projects
None yet
Development

No branches or pull requests

1 participant