Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a local disk persister #1156

Closed
2 tasks done
ankur22 opened this issue Jan 16, 2024 · 0 comments
Closed
2 tasks done

Implement a local disk persister #1156

ankur22 opened this issue Jan 16, 2024 · 0 comments
Assignees
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 16, 2024

What?

Implement a concrete type that will satisfy the interface defined by #1155, and will match the current behaviour of the browser module when a screenshot is saved to the local disk.

Why?

To enable us to be be able to either persist the screenshot to the local disk or to upload to a remote location, we need to abstract away the details from the current implementation so that a concrete type can be used which could persist in either one of those two locations.

How?

There currently is no API in k6 that allows files to be persisted to disk, so we should implement it the exact same way as we are doing now. Don't worry about making async as suggested in the current comment, but leave the comment in so that we can work on it later if we need.

Tasks

Tasks

Related PR(s)/Issue(s)

Prerequisite issue: #1155

@ankur22 ankur22 added team/k6browser To distinguish the issue on project boards. remote remote browser related labels Jan 16, 2024
@ankur22 ankur22 self-assigned this Jan 25, 2024
This was referenced Jan 25, 2024
@ankur22 ankur22 closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.
Projects
None yet
Development

No branches or pull requests

1 participant