Skip to content

Commit

Permalink
Add skip tip and windows e2e test run
Browse files Browse the repository at this point in the history
The e2e workflow for windows using the tip version of go doesn't seem
to work on Windows (or at least in the ci github action). The tip is
installed correctly, but when it comes to building the k6 binary using
xk6, xk6 seems to always execute the stable version of the go binary
and not the tip version. When running commands outside of xk6 to
verify the env vars (e.g. GOROOT) it always returns the tip paths. It's
unclear why this is happening.

For now, we're skipping the windows e2e tip workflow.
  • Loading branch information
ankur22 committed Aug 17, 2023
1 parent 95a87a4 commit 7d983cd
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ jobs:
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout code
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
uses: actions/checkout@v2
- name: Install Go
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
uses: actions/setup-go@v2
with:
go-version: 1.x
- name: Install Go tip
if: matrix.go == 'tip'
if: matrix.go == 'tip' && matrix.platform != 'windows-latest'
run: |
go install golang.org/dl/gotip@latest
gotip download
Expand All @@ -38,8 +40,10 @@ jobs:
echo "$HOME/go/bin" >> "$GITHUB_PATH"
echo "$HOME/sdk/gotip/bin" >> "$GITHUB_PATH"
- name: Install xk6
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
run: go install go.k6.io/xk6/cmd/xk6@master
- name: Build extension
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
run: |
which go
go version
Expand All @@ -49,6 +53,7 @@ jobs:
--with github.com/grafana/xk6-browser=.
./k6extension version
- name: Run E2E tests
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
run: |
set -x
if [ "$RUNNER_OS" == "Linux" ]; then
Expand All @@ -63,5 +68,6 @@ jobs:
./k6extension run "$f"
done
- name: Check screenshot
if: matrix.go != 'tip' || matrix.platform != 'windows-latest'
# TODO: Do something more sophisticated?
run: test -s screenshot.png

0 comments on commit 7d983cd

Please sign in to comment.