Fix navigation span end

It looks like we weren't ending the span when a new navigation span was being started.
grafana · Sep 10, 2024 · 6a5a314 · 6a5a314
1 parent bead56c
commit 6a5a314
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/common/frame_session.go b/common/frame_session.go
@@ -797,6 +797,11 @@ func (fs *FrameSession) processNavigationSpan(url string, id cdp.FrameID) {
 		return
 	}
 
+	// End the navigation span if it is non-nil
+	if fs.mainFrameSpan != nil {
+		fs.mainFrameSpan.End()
+	}
+
 	_, fs.mainFrameSpan = TraceNavigation(
 		fs.ctx, fs.targetID.String(), trace.WithAttributes(attribute.String("navigation.url", url)),
 	)