Skip to content

Commit

Permalink
Fix lifecycle test parallelism bug (#712)
Browse files Browse the repository at this point in the history
So far, we haven't been testing the lifecycle tests. The test variables
were captured because `t.Parallel`. This fixes it.

Related: #647, #644, #643
  • Loading branch information
inancgumus authored Jan 13, 2023
1 parent f9153fd commit 583a2ab
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/lifecycle_wait_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ func TestLifecycleWaitForNavigation(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -265,6 +266,7 @@ func TestLifecycleWaitForLoadState(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -359,6 +361,7 @@ func TestLifecycleReload(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -454,6 +457,7 @@ func TestLifecycleGotoWithSubFrame(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -525,6 +529,7 @@ func TestLifecycleGoto(t *testing.T) {
}

for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()

Expand Down

0 comments on commit 583a2ab

Please sign in to comment.