Skip to content

Commit

Permalink
Revert back to using MainFrame to recalculate Lc
Browse files Browse the repository at this point in the history
I believe that this is a protection against a scenario where the child
frame doesn't receive the CDP events to then emit the internal events.
  • Loading branch information
ankur22 committed Oct 14, 2022
1 parent 45cd802 commit 37a64e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common/frame_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func (m *FrameManager) frameLifecycleEvent(frameID cdp.FrameID, event LifecycleE
frame := m.getFrameByID(frameID)
if frame != nil {
frame.onLifecycleEvent(event)
frame.recalculateLifecycle()
m.MainFrame().recalculateLifecycle() // Recalculate life cycle state from the top
}
}

Expand Down

0 comments on commit 37a64e3

Please sign in to comment.