Skip to content

Commit

Permalink
Remove K6_BROWSER_HEADLESS=true
Browse files Browse the repository at this point in the history
Since the k6 browser module defaults to headless true already, there's
no need to be explicit about this, so we've removed it from the ci test
workflow.
  • Loading branch information
ankur22 committed Aug 17, 2023
1 parent e0bf96e commit 2be84e3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
args[1]="1"
export GOMAXPROCS=1
fi
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome K6_BROWSER_HEADLESS=true go test "${args[@]}" -timeout 5m ./...
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome go test "${args[@]}" -timeout 5m ./...
test-tip:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
go version
export GOMAXPROCS=2
args=("-p" "2" "-race")
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome K6_BROWSER_HEADLESS=true go test "${args[@]}" -timeout 5m ./...
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome go test "${args[@]}" -timeout 5m ./...
test-current-cov:
strategy:
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
list=$(echo "$list" | cut -f1 -d ' ' | sort -u | paste -sd, -)
fi
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome K6_BROWSER_HEADLESS=true go test "${args[@]}" -timeout 5m --coverpkg="$list" -coverprofile=$(echo $pkg | tr / -).coverage $pkg
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome go test "${args[@]}" -timeout 5m --coverpkg="$list" -coverprofile=$(echo $pkg | tr / -).coverage $pkg
done
grep -h -v "^mode:" *.coverage >> coverage.txt
rm -f *.coverage
Expand Down Expand Up @@ -153,4 +153,4 @@ jobs:
go get go.k6.io/k6@master
go mod tidy
cat go.mod | grep go.k6.io/k6
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome K6_BROWSER_HEADLESS=true go test "${args[@]}" -timeout 5m ./...
K6_BROWSER_EXECUTABLE_PATH=/usr/bin/google-chrome go test "${args[@]}" -timeout 5m ./...

0 comments on commit 2be84e3

Please sign in to comment.