-
Notifications
You must be signed in to change notification settings - Fork 30
Allow creating multiple connections and select which one to use #27
Conversation
I tried to keep this non-breaking which in some cases resulted in an added positional argument that takes an options struct, but relies on existing options structs if they exist. But I'm open to other alternatives, even going to options arguments across the board and thus breaking the API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase as this has merge conflicts given merge of #26 .
@javaducky sorry for the delay, I was enjoying a vacation away from a proper computer :) think it should be sorted now |
@swantzter thank you! Looks like there are some linter issues related to missing documentation for the |
@javaducky yeah I was looking at them, but I can't see how what I've done differs from how the rest of the library code does it, do you have any pointers for how to align it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With method documentation, the comment should begin with the actual name of the method/function itself.
Co-authored-by: Paul Balogh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for getting those updates!
fixes #24