Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Add headers support on queue publish #19

Merged

Conversation

acuderman
Copy link
Contributor

What is this PR for?

Adds headers support for the queue publish command.

Partially resolves #18

Signed-off-by: Andraz Cuderman [email protected]

@acuderman acuderman changed the title Added headers support for queue publish command Add headers support on queue publish Oct 26, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@javaducky javaducky self-requested a review November 2, 2022 21:15
@javaducky
Copy link
Contributor

Hi @acuderman! Thank you for your contribution.

If you would, please add to the example in the README to show the use of custom headers when publishing messages.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a README update.

Signed-off-by: Andraz Cuderman <[email protected]>
@acuderman
Copy link
Contributor Author

Hi @acuderman! Thank you for your contribution.

If you would, please add to the example in the README to show the use of custom headers when publishing messages.

Hey @javaducky, thanks for having a look. I added an example to the README.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @acuderman for your contribution!

@javaducky javaducky merged commit 4f25f55 into grafana:main Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish event with headers on exchange with routing key
3 participants