Log error when parsing GCP disk with non-JSON description #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been reported in #41. Signed-off-by: Leandro López (inkel) <[email protected]>
Signed-off-by: Leandro López (inkel) <[email protected]>
Fixes #41 Signed-off-by: Leandro López (inkel) <[email protected]>
Signed-off-by: Leandro López (inkel) <[email protected]>
Pokom
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Looks good to me! The error message is pretty helpful as well:
./unused -gcp.project $(gcloud config get project)
ts=2023-01-03T20:03:28Z msg="cannot parse disk metadata" disk="cortex-prod-04-corrupt-wal-2022-10-09" err="cannot decode JSON description for disk cortex-prod-04-corrupt-wal-2022-10-09: invalid character 'S' looking for beginning of value" project="grafanalabs-global"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #41 when trying to parse the
Descriptionfield as JSON it was returning an error if it failed, blocking the programs to continue listing the unused disks. This PR pass down a logger (logfmt.Loggermore specifically) and emits a log line instead of returning an error.