-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasource: Remove deprecated fields #963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
`json_data` and `secure_json_data` are removed in favor of the `_encoded` variants which allow arbitrary data Also, some deprecated password fields which do not work in Grafana 8+ To be merged on the next major version
julienduchesne
force-pushed
the
julienduchesne/deprecate-json-data
branch
from
July 4, 2023 23:59
0d10139
to
4f6f224
Compare
inkel
approved these changes
Jul 5, 2023
github-merge-queue bot
referenced
this pull request
in panda-den/colorful-pandas
Jul 6, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [grafana](https://registry.terraform.io/providers/grafana/grafana) ([source](https://togithub.com/grafana/terraform-provider-grafana)) | required_provider | major | `1.43.0` -> `2.0.0` | --- ### Release Notes <details> <summary>grafana/terraform-provider-grafana (grafana)</summary> ### [`v2.0.0`](https://togithub.com/grafana/terraform-provider-grafana/releases/tag/v2.0.0) [Compare Source](https://togithub.com/grafana/terraform-provider-grafana/compare/v1.43.0...v2.0.0) #### What's Changed - Datasource: Remove deprecated fields by [@​julienduchesne](https://togithub.com/julienduchesne) in [https://github.com/grafana/terraform-provider-grafana/pull/963](https://togithub.com/grafana/terraform-provider-grafana/pull/963) - Remove deprecated resources by [@​julienduchesne](https://togithub.com/julienduchesne) in [https://github.com/grafana/terraform-provider-grafana/pull/964](https://togithub.com/grafana/terraform-provider-grafana/pull/964) - Remove `cloud_stack_slug` attribute from API key by [@​julienduchesne](https://togithub.com/julienduchesne) in [https://github.com/grafana/terraform-provider-grafana/pull/965](https://togithub.com/grafana/terraform-provider-grafana/pull/965) - Remove unused fields in `synthetic_monitoring_installation` by [@​julienduchesne](https://togithub.com/julienduchesne) in [https://github.com/grafana/terraform-provider-grafana/pull/966](https://togithub.com/grafana/terraform-provider-grafana/pull/966) - Dashboard: Remove `slug` and its migration by [@​julienduchesne](https://togithub.com/julienduchesne) in [https://github.com/grafana/terraform-provider-grafana/pull/967](https://togithub.com/grafana/terraform-provider-grafana/pull/967) **Full Changelog**: grafana/terraform-provider-grafana@v1.43.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
julienduchesne
added a commit
to grafana/grafana-api-golang-client
that referenced
this pull request
Jul 10, 2023
Following grafana/terraform-provider-grafana#963 We don't need those fields anymore. We pass arbitrary maps to the API
julienduchesne
added a commit
to grafana/grafana-api-golang-client
that referenced
this pull request
Jul 10, 2023
Following grafana/terraform-provider-grafana#963 We don't need those fields anymore. We pass arbitrary maps to the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_data
andsecure_json_data
are removed in favor of the_encoded
variants which allow arbitrary dataAlso, some deprecated password fields which do not work in Grafana 8+
I'm planning on doing a major version this week removing all the deprecated fields