-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLO: Implements SLO Datasource and SLO Resource #910
Conversation
…eSLO functionality for the ResourceSLOCreate and ResourceSLORead Methods
…onality for the resourceSloDelete Methods
…onality for the resourceSloUpdate method, removes the Local Dev Testing Files
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
Latest look at our HCL Schema is here for anyone that is curious: We will stick with a nested structure, and I've extracted out a string that specifies our query type. Anything other than the string "freeform" will throw a validation error on the TF Provider side indicating that the query type hasn't been implemented yet.
|
hey @joeblubaugh - do you mind deploying the latest version of our SLO Plugin to the Once that's done, the tests should pass, and you can start your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some initial comments. Some of them imply pretty big changes (simplifying the code a bit) so I'd like to give another review after you've looked over my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about SLOs but the TF stuff looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about SLOs but the TF stuff looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about SLOs but the TF stuff looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do "freeformquery" -> "freeform" in the schema. Otherwise looks great, and once done feel free to merge.
This PR implements a SLO Datasource (READ) and a SLO Resource (CRUD + Import) to the Grafana Terraform Provider.
Needs to be reviewed in conjunction with this PR on the Grafana Go API Client
For anyone who wants to test this on sloapp, feel free to check out the instructions within slo-testing-README.md within the slo_testing directory.
Detailed steps are provided for testing the TF Provider CRUD and Import Functionality.