Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add support for alert rule groups #584

Merged
merged 30 commits into from
Aug 23, 2022
Merged

Conversation

alexweav
Copy link
Contributor

Adds support for rule groups in Unified Alerting.

go.mod Outdated Show resolved Hide resolved
to = 0
}
datasource_uid = "-100"
model = <<EOT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I designed this example to show 2 workflows. FIrst stage shows the HCL-based rule data, where the second stage shows how to do JSON-based rule data. Both are supported. First looks cleaner, second is nice if a user already has rule JSON ready to go.

@alexweav alexweav force-pushed the alexweav/alert-rules branch from aa541ac to de8f02a Compare August 17, 2022 21:21
@alexweav alexweav marked this pull request as ready for review August 17, 2022 21:40
@alexweav alexweav requested a review from a team as a code owner August 17, 2022 21:40
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small optional nit.

@alexweav alexweav force-pushed the alexweav/alert-rules branch from 7fa4108 to b731dfd Compare August 23, 2022 17:29
@alexweav alexweav merged commit bf062df into master Aug 23, 2022
@alexweav alexweav deleted the alexweav/alert-rules branch August 23, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants