Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global resources var #1432

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Mar 21, 2024

The provider package now has a function that will expose all the resources from all subcategories of the provider

This list is used to:

  • Used in the import docs generation command
  • Sent to both provider servers
  • Used in the tf code generation command

Review only the first commit, I merged #1433, forgetting that it depended on this PR here 🤦

The `provider` package now has a function that will expose all the resources from all subcategories of the provider
This list is used to:
- Used in the import docs generation command
- Sent to both provider servers
- Used in the tf code generation command
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review March 21, 2024 01:08
@julienduchesne julienduchesne requested review from a team as code owners March 21, 2024 01:08
Paving the way for TF code generation
@julienduchesne julienduchesne requested review from a team as code owners March 21, 2024 11:20
@julienduchesne julienduchesne removed request for a team March 21, 2024 11:20
Copy link
Contributor

@gerboland gerboland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from ML

@julienduchesne julienduchesne merged commit 5177bb3 into main Mar 21, 2024
25 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/remove-global-var branch March 21, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants