Cloud: Make full use of ID + import generation framework #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split from #1391 Convert the `stack` and `stack_service_account` resources to the new ID system that validates the ID format
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
K-Phoen
approved these changes
Mar 11, 2024
julienduchesne
added a commit
that referenced
this pull request
Mar 18, 2024
Regression from #1412 In that PR, I noticed that the ID format for the stack service account is incomplete It contained only the SA ID, and without the stack slug, it didn't really allow for imports I fixed it, but now read operations from the old ID format didn't work anymore To fix this, we can support the old ID format (just the SA ID) until the next major version This is unfortunately not testable with the acceptance test framework, but I tested it manually
julienduchesne
added a commit
that referenced
this pull request
Mar 18, 2024
* Fix `grafana_cloud_service_account` read Regression from #1412 In that PR, I noticed that the ID format for the stack service account is incomplete It contained only the SA ID, and without the stack slug, it didn't really allow for imports I fixed it, but now read operations from the old ID format didn't work anymore To fix this, we can support the old ID format (just the SA ID) until the next major version This is unfortunately not testable with the acceptance test framework, but I tested it manually * Fix SM http check test that now randomly fails Probably new validation in the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1391
Convert the
stackandstack_service_accountresources to the new ID system that validates the ID format