Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tempo-mixin: clear allValue so selecting All namespaces only queries Tempo namespaces #1138

Merged
merged 2 commits into from
Nov 27, 2021

Conversation

yvrhdn
Copy link
Member

@yvrhdn yvrhdn commented Nov 26, 2021

What this PR does:

This is a temporary patch until grafana/jsonnet-libs#703 is merged. Update the grafana-builder jsonnet library to include grafana/jsonnet-libs#703
More details can be found in that issue as well.

This dropdown is populated with the namespaces a Tempo cluster is running in. The current behaviour (with allValue: '.+') is confusing, because selecting All in the dropdown ends up querying all namespaces.
The previous behaviour (with allValue: null) only queries the namespaces that are returned by the query.

The reason we got confused is that in our dashboard you can select a cluster and if you know there is only 1 Tempo namespace in that cluster you kind of expect to only see data from that namespace. But with allValue: '.+' you get data from all the namespaces in that cluster. So we were mistakenly looking at queriers from a non-Tempo cluster and wondering why CPU was so high.

…Tempo namespaces

This is a temporary patch until grafana/jsonnet-libs#703 is merged.
More details can be found in that issue as well.
@annanay25 annanay25 merged commit 75689ee into grafana:main Nov 27, 2021
@yvrhdn yvrhdn deleted the kvrhdn/clear-allValue branch November 27, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants