Fix: add packages to release #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GitHub's command line tool (gh) to add packages to the existing release. The assumption is that the tag was created because there's a matching release. This feels wrong, because we are creating a release and then later, in a separate workflow, we are adding files to that release, instead of doing it in a single location. From my point of view, the problem is that we are conceptually creating a release which creates a tag instead of the other way around. It's even a little weirder because GitHub does support the concept of "draft release", but release-please doesn't. Fixes: #956 Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub's command line tool (gh) to add packages to the existing release. The assumption is that the tag was created because there's a matching release.
This feels wrong, because we are creating a release and then later, in a separate workflow, we are adding files to that release, instead of doing it in a single location. From my point of view, the problem is that we are conceptually creating a release which creates a tag instead of the other way around. It's even a little weirder because GitHub does support the concept of "draft release", but release-please doesn't.
Fixes: #956