Rework build_and_publish.yaml to handle docker images #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up the global git config to disable ownership validation, this is causing more grief than necesary and in this particular use case it doesn't really provide anything. This is possibly a bug in actions/checkout. Tear shared-workflows/build-push-to-dockerhub appart and replace it with a couple of steps (setup-buildx, build-push-action) in a way that the image created in the buildx context is exported to a tar file, so that we can reuse it in a different job to assemble a single multiarch image together. Add some intermediate steps that capture the result of building the images and uploads them as build artifacts, so that we can download them in a different job where the actual image is created. Finally, put the images together and push them to GAR. This requires reworking the dockerfiles in a way that they don't execute any platform dependent steps, and everything can be done in the host. Something broke with the chromium package, so I had to unpin it. Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up the global git config to disable ownership validation, this is causing more grief than necesary and in this particular use case it doesn't really provide anything. This is possibly a bug in actions/checkout.
Tear shared-workflows/build-push-to-dockerhub appart and replace it with a couple of steps (setup-buildx, build-push-action) in a way that the image created in the buildx context is exported to a tar file, so that we can reuse it in a different job to assemble a single multiarch image together.
Add some intermediate steps that capture the result of building the images and uploads them as build artifacts, so that we can download them in a different job where the actual image is created.
Finally, put the images together and push them to GAR. This requires reworking the dockerfiles in a way that they don't execute any platform dependent steps, and everything can be done in the host.
Something broke with the chromium package, so I had to unpin it.