Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info message for -features suggested deprecated syntax. #801

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Info message for -features suggested deprecated syntax. #801

merged 1 commit into from
Jul 22, 2024

Conversation

perjahn
Copy link
Contributor

@perjahn perjahn commented Jul 22, 2024

The "--feature" syntax is not allowed any longer.

@perjahn perjahn requested a review from a team as a code owner July 22, 2024 10:58
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@perjahn perjahn changed the title Info message for -features used deprecated syntax. Info message for -features suggested deprecated syntax. Jul 22, 2024
nadiamoe
nadiamoe approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@nadiamoe nadiamoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@nadiamoe nadiamoe merged commit 8900a1d into grafana:main Jul 22, 2024
1 check passed
mem added a commit that referenced this pull request Jul 30, 2024
@mem
Release v0.25.1
402ff0f 
* ci/renovate: update gomod digests before 8 AM UTC
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.16.0 (#800)
* Info message for -features used deprecated syntax. (#801)
* Update golang.org/x/exp digest to 8a7402a (#806)
* k6runner: handle ErrorCodeFailed (#791)
* Add retries to BBE DNS probe (#803)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.17.1 (#808)
* Update github.com/grafana/loki/pkg/push digest to 5a87ccb (#804)

Signed-off-by: Marcelo E. Magallon <[email protected]>
@mem mem mentioned this pull request Jul 30, 2024
Merged
mem added a commit that referenced this pull request Jul 30, 2024
@mem
Release v0.25.1 (#810)
f2f001c 
* ci/renovate: update gomod digests before 8 AM UTC
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.16.0 (#800)
* Info message for -features used deprecated syntax. (#801)
* Update golang.org/x/exp digest to 8a7402a (#806)
* k6runner: handle ErrorCodeFailed (#791)
* Add retries to BBE DNS probe (#803)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.17.1 (#808)
* Update github.com/grafana/loki/pkg/push digest to 5a87ccb (#804)

Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadiamoe nadiamoe nadiamoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perjahn @CLAassistant @nadiamoe