Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route browser checks to the browser prober #780

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

mem
Copy link
Contributor

@mem mem commented Jul 5, 2024

Follow-up-to: 9730c0b
Follow-up-to: db349fd

@mem mem requested a review from a team as a code owner July 5, 2024 23:03
@mem mem force-pushed the mem/fix-browser-checks branch 3 times, most recently from bfc5cc0 to 3a2e52d Compare July 6, 2024 00:02
Make sure that validate works for all check types, and make sure all
check types have at least a trivial test.

Make sure the probe factory knows how to create checks for all defined
types.

Follow-up-to: 9730c0b
Follow-up-to: db349fd
Signed-off-by: Marcelo E. Magallon <[email protected]>
@mem mem force-pushed the mem/fix-browser-checks branch from 3a2e52d to 0e484ec Compare July 6, 2024 00:08
@mem mem enabled auto-merge (squash) July 6, 2024 00:10
Copy link
Member

@nadiamoe nadiamoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mem mem merged commit ed93cf8 into main Jul 8, 2024
2 checks passed
@mem mem deleted the mem/fix-browser-checks branch July 8, 2024 12:25
nadiamoe added a commit that referenced this pull request Jul 15, 2024
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0
* grpc: nolint deprecated grpc options
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates
* http: rename `promconfig.Header` to `promconfig.ProxyHeader`
* Add the basic stuff to support a browser check type (#737)
* k6runner/test: ensure logs are sent to loki when runner reports user errors
* k6runner: send logs even if metrics are malformed
* Build(deps): Bump github.com/prometheus/common
* Bump k6 version using renovate (#745)
* Dispatch renovate workflow manually (#746)
* Update renovate (#748)
* Update dependency grafana/k6 to v0.52.0 (#749)
* Fix renovate configuration (#751)
* Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752)
* Update module github.com/dmarkham/enumer to v1.5.10 (#754)
* Update module github.com/sirupsen/logrus to v1.9.3 (#755)
* Update module github.com/stretchr/testify to v1.9.0 (#759)
* Update dependency grafana/grafana-build-tools to v0.15.0 (#756)
* Correct the listen address to scrape metrics to port 4050. (#743)
* Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0
* Update module github.com/securego/gosec to v2
* Split and fix renovate config (#767)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770)
* add validation case for browser (#773)
* Update module gotest.tools/gotestsum to v1.12.0
* Update module go.k6.io/k6 to v0.52.0
* Update golang.org/x/exp digest to 7f521ea
* Update module golang.org/x/net to v0.27.0 (#775)
* Update module github.com/securego/gosec to v2
* Update module gotest.tools/gotestsum to v1.12.0
* Update module github.com/spf13/afero to v1.11.0 (#758)
* Update module github.com/golangci/golangci-lint to v1.59.1
* Update github.com/grafana/loki/pkg/push digest to 6da364e
* Update module github.com/securego/gosec to v2
* Route browser checks to the browser prober (#780)
* Update module google.golang.org/grpc to v1.65.0 (#761)
* ci/renovate: limit gomod digest updates to once every two weeks (#785)
* Update golang.org/x/exp digest to 46b0784 (#781)
* cmd: default to sm-k6 binary
* Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6
* k6runner/test: pass address of expectErrorAs to errors.As
* k6runner: log errors encountered by logfmt parser
* Update github.com/grafana/loki/pkg/push digest to 7c86e65
* Add browser limits and class (#787)
* Update module github.com/prometheus/prometheus to v0.53.1 (#790)
* Report browser check's class as browser (#788)
* Update github.com/grafana/loki/pkg/push digest to 527510d (#793)
* Update github.com/securego/gosec/v2 digest to 4487a0c

Signed-off-by: Ro Santalla <[email protected]>
@nadiamoe nadiamoe mentioned this pull request Jul 15, 2024
nadiamoe added a commit that referenced this pull request Jul 15, 2024
* Chore(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0
* grpc: nolint deprecated grpc options
* Build(deps): Bump the prometheus-go group across 1 directory with 2 updates
* http: rename `promconfig.Header` to `promconfig.ProxyHeader`
* Add the basic stuff to support a browser check type (#737)
* k6runner/test: ensure logs are sent to loki when runner reports user errors
* k6runner: send logs even if metrics are malformed
* Build(deps): Bump github.com/prometheus/common
* Bump k6 version using renovate (#745)
* Dispatch renovate workflow manually (#746)
* Update renovate (#748)
* Update dependency grafana/k6 to v0.52.0 (#749)
* Fix renovate configuration (#751)
* Update github.com/grafana/loki/pkg/push digest to 04bc3a4 (#752)
* Update module github.com/dmarkham/enumer to v1.5.10 (#754)
* Update module github.com/sirupsen/logrus to v1.9.3 (#755)
* Update module github.com/stretchr/testify to v1.9.0 (#759)
* Update dependency grafana/grafana-build-tools to v0.15.0 (#756)
* Correct the listen address to scrape metrics to port 4050. (#743)
* Build(deps): Bump google.golang.org/grpc from 1.64.0 to 1.65.0
* Update module github.com/securego/gosec to v2
* Split and fix renovate config (#767)
* Update ghcr.io/grafana/grafana-build-tools Docker tag to v0.15.1 (#770)
* add validation case for browser (#773)
* Update module gotest.tools/gotestsum to v1.12.0
* Update module go.k6.io/k6 to v0.52.0
* Update golang.org/x/exp digest to 7f521ea
* Update module golang.org/x/net to v0.27.0 (#775)
* Update module github.com/securego/gosec to v2
* Update module gotest.tools/gotestsum to v1.12.0
* Update module github.com/spf13/afero to v1.11.0 (#758)
* Update module github.com/golangci/golangci-lint to v1.59.1
* Update github.com/grafana/loki/pkg/push digest to 6da364e
* Update module github.com/securego/gosec to v2
* Route browser checks to the browser prober (#780)
* Update module google.golang.org/grpc to v1.65.0 (#761)
* ci/renovate: limit gomod digest updates to once every two weeks (#785)
* Update golang.org/x/exp digest to 46b0784 (#781)
* cmd: default to sm-k6 binary
* Dockerfile: copy sm-specific k6 as sm-k6 instead of just k6
* k6runner/test: pass address of expectErrorAs to errors.As
* k6runner: log errors encountered by logfmt parser
* Update github.com/grafana/loki/pkg/push digest to 7c86e65
* Add browser limits and class (#787)
* Update module github.com/prometheus/prometheus to v0.53.1 (#790)
* Report browser check's class as browser (#788)
* Update github.com/grafana/loki/pkg/push digest to 527510d (#793)
* Update github.com/securego/gosec/v2 digest to 4487a0c

Signed-off-by: Ro Santalla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants