Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .github/renovate.json #750

Closed
wants to merge 1 commit into from
Closed

Fix .github/renovate.json #750

wants to merge 1 commit into from

Conversation

mem
Copy link
Contributor

@mem mem commented Jun 28, 2024

Documentation says I should use these options, renovate says I shouldn't. I guess renovate knows better.

Documentation says I should use these options, renovate says I
shouldn't. I guess renovate knows better.

Signed-off-by: Marcelo E. Magallon <[email protected]>
@mem mem requested a review from a team as a code owner June 28, 2024 00:30
@mem
Copy link
Contributor Author

mem commented Jul 2, 2024

renovate doesn't work without (some) of this options...

@ka3de
Copy link
Contributor

ka3de commented Jul 2, 2024

There is a conflict due to forkProcessing being disabled in #751. I will approve this once that's fixed.

@nadiamoe
Copy link
Member

nadiamoe commented Jul 3, 2024

Documentation says I should use these options, renovate says I shouldn't. I guess renovate knows better.
renovate doesn't work without (some) of this options...

Self-hosted renovate typically has two configuration files, one for renovate itself, which configures things like authentication, and another one for each repo that renovate manages.

With this setup of running renovate inside CI, which is not the usual way of running it, we're blurring the line a bit because we're running one renovate instance per repo. username, platform, and repositories are configs for renovate itself and not for the repo, so the bot is probably reading those in repo context and getting a bit confused.

I think the proper way to fix this is to split the configuration in two as renovate expects it. username, platform, and repositories should be on a different file referenced here:

configurationFile: .github/renovate.json

And that file should be different from the file in default paths for the repo config, which contains the rest of the config.

@nadiamoe
Copy link
Member

nadiamoe commented Jul 4, 2024

I've split the config files as renovate wants them here: https://github.com/grafana/synthetic-monitoring-agent/pull/767/files

@mem
Copy link
Contributor Author

mem commented Jul 4, 2024

Merged #767 that actually fixes this.

Thanks, @roobre

@mem mem closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants