k6runner: send logs even if metrics are malformed #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
k6script-broken-metrics
branch
from
698d447 to
00ecca4
Compare
ka3de
reviewed
Jun 26, 2024
ka3de
previously approved these changes
Jun 26, 2024
nadiamoe
force-pushed
the
k6script-broken-metrics
branch
from
00ecca4 to
70f221e
Compare
nadiamoe
force-pushed
the
k6runner-test-logs
branch
from
d67a369 to
911c174
Compare
nadiamoe
force-pushed
the
k6script-broken-metrics
branch
from
70f221e to
c65a0c4
Compare
|
Sorry @ka3de, rebasing borked your review :( |
ka3de
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards grafana/synthetic-monitoring-app#835.
When https://github.com/grafana/sm-k6-runner/pull/208 is merged, there is a theoretical possibility of the logs and/or metrics returned by the runner to be malformed, for example is k6 is killed while it is writing its output.
This PR adds tests for that case, ensuring that: