Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bump minor, not patch, for features #1111

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix: bump minor, not patch, for features #1111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/release-please/release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
".": {
"release-type": "go",
"bump-minor-pre-major": true,
"bump-patch-for-minor-pre-major": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this and, at least based on documentation, this should default to false anyway, but we can set it explicitly just in case. You can see the full config spec here: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#configfile.

I still don't understand the issue we see in #1094, as the same "behavior" worked correctly in the past with the same configuration. See #954.

"include-component-in-tag": false,
"changelog-sections": [
{ "type": "feat", "section": "Features" },
Expand Down
Loading