Base browser image on grafana/chromium-swiftshader-alpine #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
dockerfile-chromium-alpine
branch
2 times, most recently
from
935993e to
6e9ef85
Compare
The new base image is built at https://github.com/grafana/chromium-swiftshader-alpine, and should allow us to both get chromium updates as PRs, while at the same time being stable so an outdated version does not break builds in the foreseeable future.
nadiamoe
force-pushed
the
dockerfile-chromium-alpine
branch
from
6e9ef85 to
63bad77
Compare
This was referenced Nov 25, 2024
nadiamoe
commented
Nov 25, 2024
| RUN apk --no-cache add --repository community tini=0.19.0-r3 | ||
| RUN [[ "$TARGETARCH" != "amd64" ]] || apk --no-cache add --repository community --arch x86_64 chromium-swiftshader=131.0.6778.69-r0 | ||
| RUN [[ "$TARGETARCH" != "arm64" ]] || apk --no-cache add --repository community --arch aarch64 chromium-swiftshader=131.0.6778.69-r0 | ||
| RUN apk --no-cache add --repository community tini |
There was a problem hiding this comment.
I think tini is fairly stable and doesn't have much activity, so it's probably not worth setting renovate to update packages just for it. I can bring it back if someone things it's still useful.
mem
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new base image is built at https://github.com/grafana/chromium-swiftshader-alpine, and should allow us to both get chromium updates as PRs, while at the same time being stable so an outdated version does not break builds in the foreseeable future.