Update images to Ubuntu 24.04 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsotirakis
reviewed
Oct 7, 2024
| @@ -7,4 +7,4 @@ on: | |||
|
|
|||
| jobs: | |||
| build-and-publish: | |||
| uses: grafana/runner-images/.github/workflows/packer-build-and-publish.yml@main | |||
| uses: grafana/runner-images/.github/workflows/packer-build-and-publish.yml@gc/update-to-ubuntu-24 | |||
There was a problem hiding this comment.
This needs to be changed back to main?
There was a problem hiding this comment.
Yup! Sorry didn't get back to this PR but it's pending changes from #125 should only be merged after that one is done :)
There was a problem hiding this comment.
Added a TODO comment.
guicaulada
force-pushed
the
gc/update-to-ubuntu-24
branch
2 times, most recently
from
50fe2dd to
d3245a3
Compare
guicaulada
force-pushed
the
gc/update-to-ubuntu-24
branch
5 times, most recently
from
7176438 to
22277aa
Compare
guicaulada
force-pushed
the
gc/update-to-ubuntu-24
branch
from
22277aa to
e061152
Compare
guicaulada
force-pushed
the
gc/update-to-ubuntu-24
branch
from
95a2565 to
3e546db
Compare
zerok
approved these changes
Nov 8, 2024
guicaulada
force-pushed
the
gc/update-to-ubuntu-24
branch
from
ae0dc93 to
7cdcfaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During review of the recent updates from upstream I noticed
ubuntu-latesthas been moved to use Ubuntu 24.04 by default. Check: actions#10687To keep feature parity and equivalent images we should use Ubuntu 24.04 by default as well.
This PR updates our images to use Ubuntu 24.04.