Allow delayed downscale of subset of pods #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome pods at the end of statefulset are ready to be downscaled.
pracucci
approved these changes
Jun 17, 2024
| } | ||
|
|
||
| delay, prepareURL, err := parseDelayedDownscaleAnnotations(sts.GetAnnotations()) | ||
| if delay == 0 || prepareURL == nil || err != nil { | ||
| return err | ||
| return desiredReplicas, err |
There was a problem hiding this comment.
If there was an error would be more correct to return currentReplicas. Today the caller doesn't scale to updatedDesiredReplicas in case of error, but I would like to protect from future bugs.
There was a problem hiding this comment.
And follow-up fix in 7e79c3b.
There was a problem hiding this comment.
And follow-up fix in 7e79c3b.
Exactly. That's what I had in mind.
There was a problem hiding this comment.
Fortunately test caught my mistake :)
| // No change in the number of replicas: don't log because this will be the result most of the time. | ||
| continue | ||
| } | ||
|
|
||
| // We're going to change number of replicas on the statefulset. | ||
| // If there is delayed downscale configured on the statefulset, we will first handle delay part, and only if that succeeds, | ||
| // continue with downscaling or upscaling. | ||
| if err := checkScalingDelay(ctx, c.logger, sts, client, currentReplicas, desiredReplicas); err != nil { | ||
| level.Warn(c.logger).Log("msg", "not scaling statefulset due to failed scaling delay check", "group", groupName, "name", sts.GetName(), "currentReplicas", currentReplicas, "desiredReplicas", desiredReplicas, "err", err) | ||
| var desiredReplicas int32 |
There was a problem hiding this comment.
To make code more robust from future changes, I suggest to not have this initialised to 0. We could simply do:
Suggested change
| var desiredReplicas int32 | |
| desiredReplicas, err := checkScalingDelay(ctx, c.logger, sts, client, currentReplicas, referenceResourceDesiredReplicas) | |
| if err != nil { | |
| // ... | |
| } |
There was a problem hiding this comment.
Good idea, done in f7fcdb0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements earlier delayed downscale of pods that have already reached their delay, even if not ALL pods have reached it yet.
Fixes #155