Skip to content

Commit

Permalink
Fix unbalanced pairs in log. (#154)
Browse files Browse the repository at this point in the history
Fix unbalanced pairs in log, leading to a log message like this:
`level=error ts=2024-06-13T03:30:49.769575693Z pod=ingester-zone-a-16 url=http://ingester-zone-a-16.ingester-zone-a.mimir-dev.svc.cluster.local./ingester/prepare-partition-downscale errorsendingHTTPPOSTrequesttoendpoint=err`
  • Loading branch information
seizethedave authored Jun 13, 2024
1 parent fdfe18c commit 6b427ca
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* [ENHANCEMENT] Include unique IDs of webhook requests in logs for easier debugging. #150
* [ENHANCEMENT] Include k8s operation username in request debug logs. #152
* [ENHANCEMENT] `rollout-max-unavailable` annotation can now be specified as percentage, e.g.: `rollout-max-unavailable: 25%`. Resulting value is computed as `floor(replicas * percentage)`, but is never less than 1. #153
* [BUGFIX] Fix a mangled error log in controller's delayed downscale code. #154

## v0.16.0

Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/delay.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func callPrepareDownscaleAndReturnMaxPrepareTimestamp(ctx context.Context, logge

resp, err := client.Do(req)
if err != nil {
level.Error(epLogger).Log("error sending HTTP POST request to endpoint", "err", err)
level.Error(epLogger).Log("msg", "error sending HTTP POST request to endpoint", "err", err)
return err
}

Expand Down

0 comments on commit 6b427ca

Please sign in to comment.