-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore root node when converting a flamebearer to a tree. #812
Conversation
size-limit report 📦
|
ScreenshotsResult
Details
|
Codecov Report
@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 73.06% 73.06%
=======================================
Files 68 68
Lines 2357 2357
Branches 430 430
=======================================
Hits 1722 1722
Misses 607 607
Partials 28 28 Continue to review full report at Codecov.
|
@abeaumont Can you explain the issue a little bit more? |
The problem is related due to the flamebearer format. In a flamebearer, a root node When we are doing the reverse conversion, from flamebearer to tree, we need to remove this I have created a test for the Diff conversion function to showcase the problem: f7ca4a2. (I have also found out a different bug while creating that test, #820) |
No description provided.