-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): adds ability to export to flamegraph.com #799
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #799 +/- ##
==========================================
- Coverage 73.09% 72.53% -0.55%
==========================================
Files 65 65
Lines 2311 2337 +26
Branches 421 428 +7
==========================================
+ Hits 1689 1695 +6
- Misses 594 614 +20
Partials 28 28
Continue to review full report at Codecov.
|
ScreenshotsResult
Details
|
}) | ||
.catch((e) => { | ||
console.error(e); | ||
// TODO: show error to user via notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eh-am curious how you think I should implement this. I was thinking about passing some callback (errorHandler
) from the parent component to this component. That way we preserve its reusability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but at some point the best of handling this is to lift this up to receive a exportFlamegraphComFunction
, since each environment will have a different way of handling this, eg grafana.
No description provided.