Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): adds ability to export to flamegraph.com #799

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Conversation

petethepig
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 353.89 KB (+0.05% 🔺) 7.1 s (+0.05% 🔺) 331 ms (+49.24% 🔺) 7.5 s

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #799 (06164fa) into main (bee6483) will decrease coverage by 0.56%.
The diff coverage is 12.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   73.09%   72.53%   -0.55%     
==========================================
  Files          65       65              
  Lines        2311     2337      +26     
  Branches      421      428       +7     
==========================================
+ Hits         1689     1695       +6     
- Misses        594      614      +20     
  Partials       28       28              
Impacted Files Coverage Δ
webapp/javascript/components/ExportData.tsx 38.47% <12.00%> (-3.77%) ⬇️
...components/FlameGraph/FlameGraphComponent/color.ts 79.37% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee6483...06164fa. Read the comment docs.

@pyroscopebot
Copy link
Collaborator

pyroscopebot commented Feb 7, 2022

Screenshots

Throughput Throughput
Disk Usage Disk Usage
Memory Memory
Upload Errors (Total) Upload Errors (Total)
Successful Uploads (Total) Successful Uploads (Total)
CPU Utilization CPU Utilization

Result

main pr diff threshold
throughput 218.10 211.21 -6.89 (-3.21%) 5%
total items processed 65964.00 63992.00 -1972.00 (-3.03%) 5%
Details
Name Description Query for main Query for pr
throughput rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"}[5m]) rate(pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}[5m])
total items processed pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope-main:4040"} pyroscope_http_request_duration_seconds_count{handler="/ingest", instance="pyroscope:4040"}

Generated by 🚫 dangerJS against 4becf65

})
.catch((e) => {
console.error(e);
// TODO: show error to user via notifications
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eh-am curious how you think I should implement this. I was thinking about passing some callback (errorHandler) from the parent component to this component. That way we preserve its reusability.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but at some point the best of handling this is to lift this up to receive a exportFlamegraphComFunction, since each environment will have a different way of handling this, eg grafana.

@petethepig petethepig merged commit a3828bc into main Feb 7, 2022
@petethepig petethepig deleted the export branch February 7, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants