Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): Add documentation for examples/tracing/golang-push #3770

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Dec 12, 2024

As a follow up to #3765. I have slightly adapter the README. Let me know what you think. Maybe we should also update the others like that.

The README.md also mentions the opentracing spanprofiler, which we never activated, this will also active this part.

@simonswine simonswine changed the title 20241212 docs tracing golang push docs(examples): Add documentation for examples/tracing/golang-push Dec 12, 2024
@simonswine simonswine marked this pull request as ready for review December 12, 2024 10:49
@simonswine simonswine requested review from a team as code owners December 12, 2024 10:49
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonswine simonswine enabled auto-merge (squash) December 12, 2024 11:13
@simonswine simonswine merged commit e10086d into grafana:main Dec 12, 2024
18 checks passed
@simonswine simonswine added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.9 backport release/v1.10 This label will backport a merged PR to the release/v1.10 branch labels Dec 13, 2024
Copy link
Contributor

The backport to release/v1.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3770-to-release/v1.9 origin/release/v1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x e10086d4a75091fefe16fbd365e8e576e9912bd5

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3770-to-release/v1.9
# Create the PR body template
PR_BODY=$(gh pr view 3770 --json body --template 'Backport e10086d4a75091fefe16fbd365e8e576e9912bd5 from #3770{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.9] docs(examples): Add documentation for `examples/tracing/golang-push`' --body-file - --label 'type/docs' --label 'backport' --base release/v1.9 --milestone release/v1.9 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3770-to-release/v1.9

# Create a pull request where the `base` branch is `release/v1.9` and the `compare`/`head` branch is `backport-3770-to-release/v1.9`.

# Remove the local backport branch
git switch main
git branch -D backport-3770-to-release/v1.9

Copy link
Contributor

The backport to release/v1.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3770-to-release/v1.10 origin/release/v1.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x e10086d4a75091fefe16fbd365e8e576e9912bd5

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3770-to-release/v1.10
# Create the PR body template
PR_BODY=$(gh pr view 3770 --json body --template 'Backport e10086d4a75091fefe16fbd365e8e576e9912bd5 from #3770{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.10] docs(examples): Add documentation for `examples/tracing/golang-push`' --body-file - --label 'type/docs' --label 'backport' --base release/v1.10 --milestone release/v1.10 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3770-to-release/v1.10

# Create a pull request where the `base` branch is `release/v1.10` and the `compare`/`head` branch is `backport-3770-to-release/v1.10`.

# Remove the local backport branch
git switch main
git branch -D backport-3770-to-release/v1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.10 This label will backport a merged PR to the release/v1.10 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants