Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compaction block queue persistence #3532

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: compaction block queue persistence #3532

merged 1 commit into from
Aug 30, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Aug 30, 2024 •
edited
Loading

Fixes an issue where compaction block queues are stored correctly in memory but not persisted in bolt db because we are using the wrong key. Updates the tests as well to cover this.

@aleks-p aleks-p requested a review from a team as a code owner August 30, 2024 14:04
korniltsev
korniltsev approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I wonder if we had separate types jobtenantshard / blocktenantshard , maybe it could also prevent these types of errors. I do not suggest doing it now, just dumping an idea

@aleks-p aleks-p merged commit 60c0b09 into main Aug 30, 2024
18 checks passed
@aleks-p aleks-p deleted the fix/block-queues-not-persisted branch August 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleks-p @korniltsev