feat: Embed a grafana and explore-profiles instance into pyroscope #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20240716_embed-grafana
branch
from
e4fc02e to
44e6edb
Compare
simonswine
changed the title
Closed
simonswine
force-pushed
the
20240716_embed-grafana
branch
from
44e6edb to
2124995
Compare
|
To test this now you can use my image repo: Then go to http://localhost:4041 |
|
worth updating |
This provides an optional target `embedded-grafana` to download/configure/run a dedicated Grafana instance with Explore Profiles deployed. This is meant not to be used as production, but useful to quickly discover profiles. After this PR merges a user can run this: ``` $ docker run -p 4040:4040 -p 4041:4041 grafana/pyroscope --target all,embedded-grafana ``` And on localhost:4040 there will the classic pyroscope and on :4041, there will be Grafana with Explore Profiles.
simonswine
force-pushed
the
20240716_embed-grafana
branch
from
2124995 to
8e06fb4
Compare
I went with updating the contribution guide first. I think for now let's test if this works for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an optional target
embedded-grafanato download/configure/run a dedicated Grafana instance with Explore Profiles deployed.This is meant not to be used for production, but useful to quickly discover/play/develop profiles.
After this PR merges a user can run this:
And on
http://localhost:4040there will the classic pyroscope and onhttp://localhost:4041, there will be Grafana with Explore Profiles.Screen.Recording.2024-07-16.at.17.12.51.mov