Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorganize examples folder to match docs structure #3026

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

Rperry2174
Copy link
Contributor

@Rperry2174 Rperry2174 commented Feb 26, 2024

This reorganizes our examples to match the "configure the client" part of our docs. I'm not sure if this will break things in places where we use these examples.

i.e.

  • I believe in the /tracing/tempo folder we use relative references and this might mess that up cc @kolesnikovae
  • I also don't know how sedemo and play.grafana.net use these examples and if this will break those @korniltsev

image

We will also probably need to go through docs and make sure that we didn't break any links there where we link to the examples. cc @knylander-grafana :
image

@Rperry2174 Rperry2174 requested a review from a team as a code owner February 26, 2024 15:39
@Rperry2174 Rperry2174 changed the title docs: Reorganize examples folder to match docs struction docs: Reorganize examples folder to match docs structure Feb 26, 2024
@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Feb 26, 2024
@knylander-grafana
Copy link
Contributor

I searched the docs for links to the file locations changed in this PR. Here is the doc PR with those updated links: #3027

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New structure looks good. Link updates also look good. I can only approve the doc changes.

@kolesnikovae
Copy link
Collaborator

@Rperry2174 thanks for pinging me – I've pushed changed straight to the branch

@Rperry2174 Rperry2174 merged commit bab5bdd into main Feb 27, 2024
19 checks passed
@Rperry2174 Rperry2174 deleted the reorg-examples-folder branch February 27, 2024 20:39
simonswine added a commit to simonswine/pyroscope that referenced this pull request Feb 29, 2024
simonswine added a commit to simonswine/pyroscope that referenced this pull request Feb 29, 2024
simonswine added a commit that referenced this pull request Feb 29, 2024
simonswine added a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants