Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export flamegraph and table to pdf/png #143

Merged
merged 10 commits into from
Mar 31, 2021

Conversation

cjsampson
Copy link
Contributor

This PR adds the ability to export the flamegraph as a PNG/PDF and the table pane as a PDF.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #143 (e8a66e5) into main (d173be8) will increase coverage by 2.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   55.35%   57.50%   +2.16%     
==========================================
  Files          69       69              
  Lines        2631     2630       -1     
==========================================
+ Hits         1456     1512      +56     
+ Misses       1071      998      -73     
- Partials      104      120      +16     
Impacted Files Coverage Δ
pkg/agent/session.go 68.61% <0.00%> (-4.65%) ⬇️
pkg/storage/segment/segment.go 92.50% <0.00%> (-4.16%) ⬇️
pkg/server/controller.go 25.75% <0.00%> (+25.75%) ⬆️
pkg/server/ingest.go 66.04% <0.00%> (+66.04%) ⬆️
pkg/server/stats.go 66.67% <0.00%> (+66.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d173be8...e8a66e5. Read the comment docs.

Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cjsampson just a couple of small changes we appreciate you adding this for us!

webapp/sass/profile.scss Outdated Show resolved Hide resolved
webapp/sass/profile.scss Show resolved Hide resolved
webapp/javascript/components/ExportData.jsx Show resolved Hide resolved
webapp/javascript/components/ExportData.jsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants