Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(adhoc): if not spyName is available, use 'unknown' #1326

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Jul 29, 2022

As implemented in #1300
Only a certain list of spyNames are allowed (https://github.com/pyroscope-io/pyroscope/pull/1300/files#diff-4470a525fa07e3755143aea910fec818e7ad9dc18fd97f5f60203a7f43b73e79R3-R19)

In adhoc we were by default in pprof/collapsed to use the appName as the spyName.
With this PR we use unknown instead.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 410.98 KB (0%) 8.3 s (0%) 3.3 s (-11.24% 🔽) 11.5 s
webapp/public/assets/app.css 13.36 KB (0%) 268 ms (0%) 0 ms (+100% 🔺) 268 ms
webapp/public/assets/styles.css 9.8 KB (0%) 197 ms (0%) 0 ms (+100% 🔺) 197 ms
packages/pyroscope-flamegraph/dist/index.js 90.04 KB (0%) 1.9 s (0%) 1.7 s (+1.54% 🔺) 3.5 s
packages/pyroscope-flamegraph/dist/index.node.js 81.37 KB (0%) 1.7 s (0%) 520 ms (-21.99% 🔽) 2.2 s
packages/pyroscope-flamegraph/dist/index.css 5.81 KB (0%) 117 ms (0%) 0 ms (+100% 🔺) 117 ms

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1326 (e57c55b) into main (fcc9330) will decrease coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   68.45%   67.58%   -0.86%     
==========================================
  Files         116      119       +3     
  Lines        3860     3960     +100     
  Branches      887      906      +19     
==========================================
+ Hits         2642     2676      +34     
- Misses       1216     1282      +66     
  Partials        2        2              
Impacted Files Coverage Δ
webapp/javascript/services/render.ts 24.00% <0.00%> (-6.55%) ⬇️
webapp/javascript/util/updateRequests.ts 13.34% <0.00%> (-1.48%) ⬇️
webapp/javascript/components/Sidebar.tsx 86.91% <0.00%> (-0.90%) ⬇️
webapp/javascript/redux/reducers/continuous.ts 26.23% <0.00%> (-0.71%) ⬇️
webapp/javascript/pages/constants.ts 100.00% <0.00%> (ø)
webapp/javascript/pages/math.ts 100.00% <0.00%> (ø)
webapp/javascript/util/appendLabelToQuery.ts 23.08% <0.00%> (ø)
packages/pyroscope-models/src/groups.ts 100.00% <0.00%> (ø)
packages/pyroscope-models/src/index.ts 80.00% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc9330...e57c55b. Read the comment docs.

@petethepig petethepig self-requested a review August 1, 2022 17:43
@eh-am eh-am merged commit 61384d9 into main Aug 1, 2022
@eh-am eh-am deleted the fix/adhoc-spyname branch August 1, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants