-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webapp): tag selector overflow #1055
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 71.67% 70.97% -0.69%
==========================================
Files 85 85
Lines 2894 2921 +27
Branches 618 624 +6
==========================================
- Hits 2074 2073 -1
- Misses 817 845 +28
Partials 3 3
Continue to review full report at Codecov.
|
@eh-am I adjusted query input overflow, but solution isn't ideal, because at the same time this UI element is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Just out of curiosity, did you try solving this with CSS only?
Somehow making the <code>
element having the same width as the input box.
Then we don't have to do the
style={{ width: `calc(${inputWidth}px - 0.75em)` }}
part, which seems a little bit finicky.
But yeah it doesn't seem too trivial, it probably requires creating a wrapper around both the input and the code part, so that they both share the same width, then making one of them position: absolute
.
2ba30fb
to
421db1f
Compare
/create-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good for me! One thing I noticed is that ctrl+enter is not submitting the query.
It works in the same way as at https://demo.pyroscope.io/. UI detects if user changed query string inside of input, if so, it allows user submitting by ctrl+enter. Should I add possibility to submit all requests despite if they didn't change? UPD: You are right, just found the issue. UPD2: This issue is fixed |
FIX: #1043
DEMO:
2 important things
<input>
was changed to<textarea>
, I usereact-textarea-autosize
for correct resizing query textarea. This npm module was already injected to Pyroscope as submodule before.<textarea>
and<code>
and keep them matching each other.