Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Selecting a single bar on the timeline #713

Closed
Rperry2174 opened this issue Jan 12, 2022 · 0 comments
Closed

Enable Selecting a single bar on the timeline #713

Rperry2174 opened this issue Jan 12, 2022 · 0 comments
Assignees

Comments

@Rperry2174
Copy link
Contributor

Rperry2174 commented Jan 12, 2022

This is closely related to #99 , but splitting this out to make that issue simpler -- also related to #621

Added functionality

Goal: Be able to click on distinct yellow bars to render the profile for that specific timestamp

We've had some request that from a UX perspective it would be ideal to also be able to "click" on a yellow bar as opposed to having to drag from before and after in order.

Basically there are some situations where the timeline is so long, that yellow bars are not distinct from each other. In these situations this functionality would not be available and one would drag to "zoom" in on a time period as usual:
6 months of data (each bar is 10s so you can't select an individual bar here)
image

However in other situations when you are looking at a more granular time range, one could and should be able to click on a specific yellow bar and have that flamegraph rendered:

15 minutes of data (each bar is 10s so you can select an individual bar here)
image

For situations like these <15minutes, we should:

  1. Make the width of the bars a little bit wider
  2. When a bar is "hovered" over it should go into a hover state that indicates visually that the yellow bar can be "clicked" on
@shaleynikov shaleynikov self-assigned this Jan 21, 2022
korniltsev pushed a commit that referenced this issue Jul 18, 2023
* Separate handlers in querier fronted

* Clarify http responce decompression implementation details

* Draft query time split

* Split SelectSeries by time

* Align interval to step duration

* Remove unused code

* Add querier.max-concurrent option

* Fix connect headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants