Bump async profiler #170
Merged
Bump async profiler #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
approved these changes
Nov 28, 2024
| @@ -135,60 +126,4 @@ private static String targetLibraryFileName(final String libraryFileName) throws | |||
|
|
|||
| return libraryFileName.substring(0, libraryFileName.length() - 3) + "-" + checksum + ".so"; | |||
| } | |||
|
|
|||
| @@ -13,14 +13,14 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu, macos] | |||
| java: ['8', '11', '17'] | |||
There was a problem hiding this comment.
Does the new asprof not work with java 8? or do they just not test it? I had an impression that java 8 will be alive for ages?
There was a problem hiding this comment.
The macOS pipeline for Java 8 failed: https://github.com/grafana/pyroscope-java/actions/runs/12037050274/job/33559780132
basically there is no adopt (temurin) jdk for macOS arm64 as reported here: actions/setup-java#625 and adoptium/adoptium#96
We could switch to Zulu or split the matrix up into ubuntu and macos builds
There was a problem hiding this comment.
switched to zulu for now, shouldn't make a difference for building/testing
aleks-p
force-pushed
the
bump-async-profiler
branch
from
9d29413 to
048bc26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #168.
Updates the underlying profiler to include the following changes in async-profiler: async-profiler/async-profiler@4e441b4...6682ad6.
Depends on grafana/async-profiler#4 being merged and a new version of
grafana/async-profilerbeing produced (3.0.0.1). ✅Main changes here:
grafana/async-profiler