Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.23 panic at initialization #118

Closed
korniltsev opened this issue Aug 14, 2024 · 0 comments · Fixed by #119
Closed

go 1.23 panic at initialization #118

korniltsev opened this issue Aug 14, 2024 · 0 comments · Fixed by #119

Comments

@korniltsev
Copy link
Collaborator

korniltsev commented Aug 14, 2024 •
edited
Loading 

Running target: Coverage

exec: go "test" "./pkg/..." "-coverpkg" "./..." "-v" "-cover" "-coverprofile=coverage/backend.out"

	github.com/grafana/clickhouse-datasource/pkg		coverage: 0.0% of statements

panic: pattern "GET /debug/pprof/" (registered at /usr/local/go/src/net/http/pprof/pprof.go:100) conflicts with pattern "/debug/pprof/delta_heap" (registered at /go/pkg/mod/github.com/grafana/pyroscope-go/[email protected]/http/pprof/pprof.go:24):

	GET /debug/pprof/ matches fewer methods than /debug/pprof/delta_heap, but has a more general path pattern
This was referenced Aug 14, 2024
Merged
Open
@walldiss walldiss mentioned this issue Aug 22, 2024
Merged
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this issue Aug 26, 2024
@julienduchesne
Fix merge conflict from two PRs
b023e6c 
Tests are failing due to:
- #1764
- #1763

The `go.mod` update is needed for Go 1.23 due to grafana/pyroscope-go#118
@julienduchesne julienduchesne mentioned this issue Aug 26, 2024
Merged
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this issue Aug 27, 2024
@julienduchesne
Fix merge conflict from two PRs (#1779)
b0fbf99 
* Fix merge conflict from two PRs
Tests are failing due to:
- #1764
- #1763

The `go.mod` update is needed for Go 1.23 due to grafana/pyroscope-go#118

* Use only alpha chars
This was referenced Sep 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid panic in init godeltaprof/http/pprof for go 1.23 grafana/pyroscope-go
1 participant
@korniltsev