fix: remove notification failure policy log record when prevent posting is set #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
added
pr:no public docs
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
had a problem deploying
to
github-pages
GitHub Actions
Error
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matiasb
approved these changes
Nov 19, 2024
| | Q( | ||
| Q(type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_SUCCESS) | ||
| & Q( | ||
| notification_error_code=UserNotificationPolicyLogRecord.ERROR_NOTIFICATION_POSTING_TO_SLACK_IS_DISABLED |
There was a problem hiding this comment.
Wondering if we need to check for both conditions or just checking for the "disabled" error code would be enough?
There was a problem hiding this comment.
@Ferril mentioned another case when posting alert groups in slack is disable by route, for that case we still want it to show up I think.
| @@ -528,7 +528,7 @@ def perform_notification(log_record_pk, use_default_notification_policy_fallback | |||
| ) | |||
| UserNotificationPolicyLogRecord( | |||
| author=user, | |||
| type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_FAILED, | |||
| type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_SUCCESS, | |||
There was a problem hiding this comment.
FWIW, for the notification auditor SUCCESS or FAILED are equally good (just in case).
…cords_for_log_report to reduce user confusion
mderynck
force-pushed
the
mderynck/remove-prevent-from-posting-fail-log
branch
from
57045d8
to
3d8e130
Compare
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mderynck
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes UserNotificationPolicyLogRecord to success when slack_prevent_posting is set as the user has already been notified in slack or another method in their personal notification preferences. These entries have also been filtered out of the alert group history timeline as they were causing confusion to users thinking notifications failed when in fact they had already been sent.
Which issue(s) this PR closes
https://github.com/grafana/support-escalations/issues/13236
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.