Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Teams referred to as "Ms Teams" in user settings tabs #4335

Open
seizethedave opened this issue May 10, 2024 · 1 comment
Open

MS Teams referred to as "Ms Teams" in user settings tabs #4335

seizethedave opened this issue May 10, 2024 · 1 comment

Comments

@seizethedave
Copy link
Contributor

Just a capitalization issue I noticed.

{showMsTeamsConnectionTab && (
<Tab
active={activeTab === UserSettingsTab.MSTeamsInfo}
label="Ms Teams Connection"
key={UserSettingsTab.MSTeamsInfo}
onChangeTab={getTabClickHandler(UserSettingsTab.MSTeamsInfo)}
data-testid="tab-msteams"
/>
)}

@jtheory
Copy link

jtheory commented Aug 8, 2024

We should fix this; I came here to raise this issue and found it already here.

Separately (maybe worth a separate issue, since it's not quite as trivial to fix) the tab gets cut off:
image

I'm testing in Firefox. It could fix this to simplify the tab names by dropping the word "Connection" -- "Mobile app", "Slack", "Telegram", "MS Teams".

I'm running Firefox on Ubuntu., no zoom.

shyamal2411 added a commit to shyamal2411/oncall that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants