-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add Mimir dashboards example screenshots to doc #992
Conversation
7fa9d5f
to
ee1a2b7
Compare
operations/mimir-mixin-screenshots/automation/generate-screenshots.sh
Outdated
Show resolved
Hide resolved
ee1a2b7
to
0b50041
Compare
Signed-off-by: Marco Pracucci <[email protected]>
0b50041
to
71d5734
Compare
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
weight: 170 | ||
--- | ||
|
||
# Slow queries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a good example to show here, so no screenshot.
weight: 140 | ||
--- | ||
|
||
# Top tenants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a good example to show here, so no screenshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some room for fun. :)
Signed-off-by: Marco Pracucci <[email protected]>
@chri2547, here are a set of files that are getting auto-generated that we need to know about when refactoring content. |
Tooling looks awesome. One feature-request: can we have GRAFANA_PORT in |
Signed-off-by: Marco Pracucci <[email protected]>
Good idea, done! I just named it |
Thank you, just tested it and it works great. |
Signed-off-by: Marco Pracucci <[email protected]>
await page.screenshot({path: screenshotPath}); | ||
await page.close(); | ||
|
||
// Optimize the png (lossless) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pngquant
is actually lossy, but I haven't really noticed change of quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, with your parameters, maybe not :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I configured it with --quality 100
which, according to the doc, means that doesn't apply the optimization if quality is not at least 100
(which is the max). That's all I "know".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, very nice!
This looks great, thanks for creating this tool, @pracucci. We'd definitely be interested in seeing where else we can use this to generate screen shots. A couple of questions:
|
I pull data from one of our dev cluster that we use to test Mimir. It contains no production data and no customer data.
Do you mean if I mangle the web page before taking the screenshot? If that's the question, then no, I don't. I take the screenshot of the page "as is". |
Super, that's what we need.
Yes, that was my question. Great, that helps me understand what this tool can do. Thanks again. |
What this PR does:
In this PR I propose to add Mimir dashboards screenshots to our doc. Screenshots are generated with a command and the proposal is to update them as part of the release process.
I've also introduced a tool to serve the dashboards locally running
make mixin-serve
which I think it's very useful while developing changes to dashboards jsonnet in order to have a quick feedback look (I've already used it and save me tons of time).Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]