Rename default image config field from 'cortex' to 'mimir' #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
14 tasks
simonswine
approved these changes
Jan 26, 2022
| @@ -5,18 +5,19 @@ | |||
| memcachedExporter: 'prom/memcached-exporter:v0.6.0', | |||
|
|
|||
| // Our services. | |||
| cortex: 'cortexproject/cortex:v1.9.0', | |||
| mimir: 'cortexproject/cortex:v1.9.0', | |||
There was a problem hiding this comment.
Maybe worth creating an issue or TODO to remind us to upgrade that image reference after it's been pushed.
There was a problem hiding this comment.
I will take care of that right after this PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As part of my work to cleanup jsonnet, in this PR I'm renaming the default image config field from
cortextomimir, and I'm adding support to override the overrides-exporter image.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]