Remove unused compactor code #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pstibrany
commented
Jan 25, 2022
| m4.MinTime = 0 | ||
| m4.MaxTime = 2 * time.Hour.Milliseconds() | ||
|
|
||
| var m5 metadata.Meta |
There was a problem hiding this comment.
Added extra block, otherwise m4 would have nothing to merge with.
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Jan 25, 2022
| @@ -91,16 +93,29 @@ func TestSyncer_GarbageCollect_e2e(t *testing.T) { | |||
| m3.Compaction.Level = 3 | |||
| m3.Compaction.Sources = ids[:9] // last source ID is not part of level 3 block. | |||
| m3.Thanos.Downsample.Resolution = 0 | |||
| m3.MinTime = 0 | |||
There was a problem hiding this comment.
Why don't we need it for m1 and m2?
There was a problem hiding this comment.
We only need it for blocks that are passed to SplitAndMergeGrouper, that is metas[9], m3, m4 and m5. I can set it for all blocks if you prefer.
There was a problem hiding this comment.
(Sorry for sending obsolete answer too. It's deleted now.)
pracucci
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR removes unused code left in compactor package, after Mimir switched to using split-and-merge compactor only.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]